mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-10-30 07:37:38 +00:00

Files

T

Vitor PamplonaandClaude Opus 5.5 395af4dc9c chore(skills): consolidate 33 skills into 14, verified against the tree

The 33 descriptions (~16k chars, ~19k with paths) overran Codex's skill-list
budget (2% of the context window, or 8,000 chars when unknown), and a review
found most bodies stale: paths from before the commons/commonsUI moves, the
deleted legacy desktop app, a callback signer API that no longer exists, and
example APIs that were never in the tree.

Kept, rewritten and checked against the code (every path, class and command):
account-state (+feeds), amy-expert, android-expert, auth-signers,
compose-expert (+API style, Navigation 3 back stacks), desktop-expert
(+run/package), event-store-semantics (+NIP-50 search), find-missing-
translations, kotlin-coroutines (+structured concurrency, flow modeling),
kotlin-multiplatform (+Gradle, composable extraction), ngit-pr,
nip85-trusted-assertions, nostr-expert (+NIP lookup, generated NIP catalog),
relay-client.

Dropped: textbook Compose/Kotlin technique skills, kotlin-expert,
kotlin-types-value-class, gradle-expert, quartz-integration (external-facing;
see the Quartz docs commit), find-non-lambda-logs (audit finished; the rule is
now in AGENTS.md Kotlin Style), and the /nip, /desktop-run, /extract commands.
The skill list is now ~4k chars. Also drops .claude/core-skills-plan.md
(stale history) and repoints SearchableEvent's KDoc to event-store-semantics.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-11 12:21:01 -04:00

3.1 KiB

Raw Permalink Blame History

Extracting an Android composable, screen or ViewModel

Goal: Android and Desktop render the same code. First check the component's dependencies actually allow sharing; if one Android API remains, put it behind a port or slot rather than leaving the whole screen in amethyst/.

Steps

Locate it and its callers. Android code lives in amethyst/src/main/java/.
```
git grep -n "fun Name\b\|class Name\b" -- amethyst/src
```
List what ties it to Android: android.* imports, Context/Intent, R.string/R.drawable, LocalContext, Android-only libraries (media3, CameraX, WebView), and app-only helpers from amethyst/.
Move strings first. Keys still in amethyst/src/main/res/values/strings.xml move with tools/strings-migrate/migrate.py <keys…> (all locales, byte for byte), then R.string.x becomes Res.string.x. Rules: AGENTS.md › Strings.
Pick the destination (mechanical rule in commonsUI/ARCHITECTURE.md):
- Composables, screens, anything importing Compose UI, Coil or Res → commonsUI/src/commonMain/, same com.vitorpamplona.amethyst.commons.* package tree.
- Headless ViewModels, state holders, services → commons/src/commonMain/ (viewmodels/ or <feature>/), never under a ui.* package.
- Nostr protocol logic → quartz/src/commonMain/.
Replace Android APIs (table below). Each leftover platform need becomes an expect/actual verb, a port, or a slot (see SKILL.md).
Repoint callers in amethyst/ to the shared version and delete the Android copy. Desktop renders the shared UI, so it usually needs no change beyond any new port/actual.
Verify: compile every target the module builds, ./gradlew :commonsUI:jvmTest :commonsUI:verifyKmpPurity (or :commons:…), ./gradlew :amethyst:compilePlayDebugKotlin, then ./gradlew spotlessApply.

Common replacements

Android	Shared
`stringResource(R.string.x)`	`stringRes(Res.string.x)` (`commons/ui/StringRes.kt`); `pluralStringRes(Res.plurals.x, n, …)`
String outside composition	`loadStringRes(…)` from a coroutine, or resolve in composition and pass a `String`
`painterResource(R.drawable.x)`	`painterRes(Res.drawable.x, …)` (`commons/ui/PainterRes.kt`)
`Toast.makeText(…)` in UI	`accountViewModel.toastManager.toast(…)`
Toast/message from headless code	report a typed `UserNotice` (`commons.notices`) to a `UserNoticeSink`; word it in `commonsUI` `notices/ui/UserNoticeText.kt`
`LocalContext.current` for share / open URI	`rememberTextSharer()`, `rememberBlossomUriOpener()`, Compose `LocalUriHandler`
`LocalContext.current` for anything else	a port on `AccountViewModelHost`, a slot such as `LocalNotePlatform`, or a lambda parameter
Platform media/map/editor inside a note	`LocalNotePlatform` slot
`Intent` to another screen	the shared navigation in `commonsUI` (`AmethystApp`)
Per-window-size layout forks	`ScreenLayoutSpec` / `LocalScreenLayout`
`@StringRes Int` field	`StringResource` / `PluralStringResource`

3.1 KiB Raw Permalink Blame History Unescape Escape

Extracting an Android composable, screen or ViewModel

Steps

Common replacements

3.1 KiB

Raw Permalink Blame History