mirror of
https://github.com/vitorpamplona/amethyst.git
synced 2026-10-30 07:37:38 +00:00
Vitor PamplonaandClaude Opus 5.5
d6a5382e58
Codex (run locally) added AGENTS.md, .agents/skills symlinks and a .codex push hook; this makes both agents read one copy of everything: - AGENTS.md is now the single source of the project rules. .claude/CLAUDE.md imports it with @../AGENTS.md and keeps only Claude-specific notes; the res/ guide moves to amethyst/src/main/res/AGENTS.md the same way. - .agents/skills/<name> are symlinks to .claude/skills/<name>, never copies. - The push checks move to tools/agent-hooks/, run by .claude/settings.json, .codex/hooks.json (matched to Bash and the PR tool) and CI. The Codex hook now also runs spotless. The shared gate accepts Codex's payloads. - New agent_config_check.py (pre-push and CI) enforces the layout: symlinks, CLAUDE.md imports, AGENTS.md under Codex's 32 KiB doc limit, description length, the combined skill-list budget, and that every path a skill cites exists. - Fixes the Compose-escaping pre-push hook, which exited 1 on a hit and so never blocked a push (PreToolUse blocks only on exit 2). - Live docs point at AGENTS.md instead of .claude/CLAUDE.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
40 lines
1.7 KiB
Bash
Executable File
40 lines
1.7 KiB
Bash
Executable File
#!/bin/bash
|
|
# PreToolUse gate: no locale string may outlive its default-locale key.
|
|
#
|
|
# Fires on `git push` (Bash tool) and on the create_pull_request MCP tool.
|
|
# Delegates to orphan_strings_check.py, which compares every
|
|
# `values-<locale>/*.xml` resource name against the union of names declared in
|
|
# that tree's default `values/*.xml`. Anything present in a locale but absent
|
|
# from the default is an orphan: in an Android res tree Android lint reports it
|
|
# as an [ExtraTranslation] ERROR, which aborts `:amethyst:lint<Variant>` and
|
|
# therefore the whole `test-and-build-android` CI job.
|
|
#
|
|
# Why a dedicated hook instead of "just run lint": `:amethyst:lintFdroidBenchmark`
|
|
# takes ~19 minutes on a warm daemon, so nobody runs it per-commit. This check is
|
|
# a directory scan and finishes in well under a second.
|
|
#
|
|
# Run the scan by hand any time with: tools/agent-hooks/orphan_strings_check.py
|
|
set -uo pipefail
|
|
|
|
hook_dir="$(cd "$(dirname "$0")" && pwd)"
|
|
# Shared by Claude Code (.claude/settings.json) and Codex (.codex/hooks.json):
|
|
# resolve the repo from this script, not from either tool's env vars.
|
|
cd "$hook_dir/../.." || exit 0
|
|
|
|
# --- Is this call a push/PR boundary? ---
|
|
payload="$(cat)"
|
|
|
|
# Cheap pure-bash pre-filter before paying for a python spawn. The gate below
|
|
# can only answer "yes" for a payload containing "push" (a git push command) or
|
|
# "pull_request" (the create_pull_request MCP tool), so anything else is a
|
|
# guaranteed no. This hook runs on EVERY Bash tool call, and the spawn it skips
|
|
# costs ~35ms each time.
|
|
case "$payload" in
|
|
*push*|*pull_request*) ;;
|
|
*) exit 0 ;;
|
|
esac
|
|
|
|
printf '%s' "$payload" | python3 "$hook_dir/lib/git_push_gate.py" || exit 0
|
|
|
|
exec python3 "$hook_dir/orphan_strings_check.py"
|