mirror of
https://github.com/jmcorgan/fips.git
synced 2026-10-30 07:37:36 +00:00
Johnathan Corgan
1ce3f578e4
The node-synthetic group is an allow-list of test modules, and an allow-list goes stale the day the next socket test lands: the new module runs beside the others and the first sign is a dropped handshake on a loaded runner, far from the cause. testing/check-node-test-groups.py recomputes the membership. It flags every function under src/node/tests/ (and in src/testutil.rs) that uses a socket primitive or calls a flagged function, to a fixpoint, so modules that reach a socket only through a helper are caught. Module names come from mod.rs's declarations. It then evaluates both profiles' overrides in order, as nextest does, and fails when a test in a flagged module is not in node-synthetic or a lock_large_network_test() holder is not in node-large. It also checks the nextest pin in the workflows matches the config. It exits 2 rather than pass when it finds no test modules, no flagged module, no lock holder, or a filter it cannot evaluate, so a moved directory or a reformatted filter cannot pass vacuously. Uses that open no socket are exempted one function and primitive at a time, each with its reason, in testing/node-test-groups/exemptions.toml. The fixtures beside it cover each way a test reaches a socket and each check the guard makes; every case names the output it expects, so a case that fails for the wrong reason fails the runner. Both run from local CI's guards and from the ci-parity job.
14 lines
765 B
TOML
14 lines
765 B
TOML
# Primitive uses that open no socket, for testing/check-node-test-groups.py.
|
|
#
|
|
# Each entry exempts one primitive in one function, named as the check
|
|
# reports it (<module>[::<inline mod>][::<impl type>]::<fn>). Any other
|
|
# primitive in that function, and any flagged helper it calls, still flags its
|
|
# module. An entry needs a reason saying why no socket is opened; one naming a
|
|
# function this branch lacks is reported as a note, since one file serves
|
|
# maint, master and next.
|
|
|
|
[[exempt]]
|
|
fn = "heartbeat::a_failing_peer_is_retried_after_the_gap_and_not_before"
|
|
primitive = "UdpTransport"
|
|
reason = "The UDP transport is built and never started, so its send fails with NotStarted before any socket exists; the test's nodes use the in-process loopback transport."
|