mirror of
https://github.com/greenart7c3/Amber.git
synced 2026-10-30 06:47:33 +00:00
greenart7c3
d8e4caad67
Android Studio's batch inspections reported about 800 problems besides spelling, which the project profile now leaves off (it mostly flagged the translations). Real bugs among them: the desktop's strings files had empty strings where Android has translations (German, Spanish, Brazilian Portuguese, Chinese), showing blank text; and IS_FDROID_BUILD, which the F-Droid workflow flips with sed, was read as a constant the IDE wanted to simplify away, so it is now read through BuildFlavorChecker.isFdroidBuild(). Account loads in coroutines (relay, intent and UI paths) and logout no longer block a thread with runBlocking; the blocking ContentProvider path and the desktop lock say why they do. Also remove what was dead (the drawable IconRow overload, PermissionCard, ConfirmationToastMsg, the desktop OkHttpWebSocket.Builder and DeleteAfterType.screenCode, the QR drawer's zero corner radius math and the strings only they used), move to the Duration overloads, give subject-less when blocks their subject, drop redundant opt-ins, suspend modifiers, qualifiers and SAM constructors, fix broken KDoc links, take the ktlint and KSP plugin versions from the catalog, strip editor metadata from the SVGs, align the Markdown tables and fix real grammar and spelling in comments, docs and three English strings.
60 lines
2.0 KiB
Markdown
60 lines
2.0 KiB
Markdown
<!--
|
||
Thanks for contributing to Amber! Before opening this PR, please skim
|
||
CONTRIBUTING.md, especially "Proof of testing" if you are not a regular
|
||
contributor to this repo.
|
||
|
||
Delete any section below that doesn't apply.
|
||
-->
|
||
|
||
## Summary
|
||
|
||
<!-- 1–3 sentences. What changed and why. Not "what files changed": the diff
|
||
already shows that. -->
|
||
|
||
## Test plan
|
||
|
||
<!-- Required. What did you actually run, on which device and flavor, and
|
||
what happened? "CI is green" is necessary but not sufficient: show the new
|
||
path running.
|
||
|
||
For signing / permission / key changes: say which request paths you exercised
|
||
(nostrsigner:// intent, ContentProvider, NIP-46 bunker) and in which states
|
||
(locked screen, Tor on/off, cold start) if they matter.
|
||
For UI changes: attach screenshots (light + dark) or a short recording, plus
|
||
device model and Android version.
|
||
For build/packaging changes: paste the ./gradlew command and the tail of the
|
||
output.
|
||
|
||
If you are NOT a regular contributor, this section is required however small
|
||
the change is. See CONTRIBUTING.md § Proof of testing. -->
|
||
|
||
- [ ] `./gradlew ktlintCheck detektAll lint` passes
|
||
- [ ] `./gradlew test` passes
|
||
- [ ] `./gradlew assembleDebug` builds both flavors
|
||
- [ ] Tested by hand on a device or emulator (notes below)
|
||
- [ ] Checked the `offline` flavor, or the change can't affect it
|
||
- [ ] New or changed strings are translated in every locale
|
||
|
||
Device / Android version / flavor:
|
||
|
||
Notes / screenshots:
|
||
|
||
<!-- paste here -->
|
||
|
||
## AI assistance
|
||
|
||
<!-- We accept AI-assisted PRs under the same rules as handwritten ones. -->
|
||
|
||
- [ ] Drafted with AI assistance, then fully reviewed and tested by hand
|
||
- [ ] Written by hand
|
||
|
||
If "Drafted with AI assistance" is ticked, a human must have reviewed the
|
||
whole diff and tested the app by hand on a device before this PR was opened.
|
||
See [`CONTRIBUTING-WITH-AI.md`](https://github.com/greenart7c3/Amber/blob/master/CONTRIBUTING-WITH-AI.md).
|
||
|
||
## License
|
||
|
||
- [ ] By submitting this PR, I agree to license my contribution under the
|
||
MIT license. Any code I did not write personally carries its original
|
||
license header.
|