mirror of
https://github.com/vitorpamplona/amethyst.git
synced 2026-10-30 07:37:38 +00:00
davotoula
c9bfdac55c
The hook comment keeps what is local to it and points at build.yml's lint-android note instead of retelling CI's memory history. CI's lint step names the hook's debug twin so a variant change lands in both. The ngit-pr skill's gate comment says what the invocation is for rather than listing the hook's contents, and its failure table gains the UnsafeOptInUsageError row. Three places that said Android lint is not a local gate now say it runs on push.
40 lines
1.7 KiB
Bash
Executable File
40 lines
1.7 KiB
Bash
Executable File
#!/bin/bash
|
|
# PreToolUse gate: no locale string may outlive its default-locale key.
|
|
#
|
|
# Fires on `git push` (Bash tool) and on the create_pull_request MCP tool.
|
|
# Delegates to orphan_strings_check.py, which compares every
|
|
# `values-<locale>/*.xml` resource name against the union of names declared in
|
|
# that tree's default `values/*.xml`. Anything present in a locale but absent
|
|
# from the default is an orphan: in an Android res tree Android lint reports it
|
|
# as an [ExtraTranslation] ERROR, which aborts `:amethyst:lint<Variant>` and
|
|
# therefore the whole `test-and-build-android` CI job.
|
|
#
|
|
# Why a dedicated hook instead of "just run lint": `:amethyst:lint<Variant>` takes
|
|
# minutes, so it is a pre-push gate (`:amethyst:lintPlayDebug` in `.git-hooks/pre-push`),
|
|
# not a per-commit one. This check is a directory scan and finishes in well under a second.
|
|
#
|
|
# Run the scan by hand any time with: tools/agent-hooks/orphan_strings_check.py
|
|
set -uo pipefail
|
|
|
|
hook_dir="$(cd "$(dirname "$0")" && pwd)"
|
|
# Shared by Claude Code (.claude/settings.json) and Codex (.codex/hooks.json):
|
|
# resolve the repo from this script, not from either tool's env vars.
|
|
cd "$hook_dir/../.." || exit 0
|
|
|
|
# --- Is this call a push/PR boundary? ---
|
|
payload="$(cat)"
|
|
|
|
# Cheap pure-bash pre-filter before paying for a python spawn. The gate below
|
|
# can only answer "yes" for a payload containing "push" (a git push command) or
|
|
# "pull_request" (the create_pull_request MCP tool), so anything else is a
|
|
# guaranteed no. This hook runs on EVERY Bash tool call, and the spawn it skips
|
|
# costs ~35ms each time.
|
|
case "$payload" in
|
|
*push*|*pull_request*) ;;
|
|
*) exit 0 ;;
|
|
esac
|
|
|
|
printf '%s' "$payload" | python3 "$hook_dir/lib/git_push_gate.py" || exit 0
|
|
|
|
exec python3 "$hook_dir/orphan_strings_check.py"
|