mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-07-22 07:48:27 +00:00

Files

nrobi144 7ff4d8e3b7 fix(desktop): avatar ripple + P3 hardcoded colors + inline shapes

Avatar/Account switcher:
- Rewrite SidebarAccountHeader with same shape/hover as other nav items
- Entire row (avatar + display name) is clickable with rounded clip
- Inline DropdownMenu replaces overlaid AccountSwitcherDropdown
- Collapsed: compact avatar with same rounded hover treatment

P3 #004 — Hardcoded status colors:
- Add StatusGreen/StatusRed/StatusAmber to commons Colors.kt
- Replace 32 inline Color() values across 10 files with theme tokens
- Color.Red → MaterialTheme.colorScheme.error where appropriate
- Color.Green/Gray → StatusGreen/onSurfaceVariant

P3 #005 — Inline shapes:
- RoundedCornerShape(8.dp) → MaterialTheme.shapes.small (~20 files)
- RoundedCornerShape(12.dp) → MaterialTheme.shapes.medium
- RoundedCornerShape(16.dp) → MaterialTheme.shapes.large
- Pill shapes (100dp/999dp) kept as-is

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-05-29 07:02:52 +03:00

1.3 KiB

Raw Blame History

status, priority, issue_id, tags

status

priority

issue_id

Feed content needs more margin below search bar

Problem Statement

When the search bar is expanded, feed items below get partially hidden by the expanded search card. The spacer height (60dp) that reserves space for the header is not enough when the search card expands with history/results.

Findings

FeedScreen.kt line 587: Spacer(Modifier.height(60.dp)) reserves space for the collapsed header only
When search expands, the card grows downward but the feed content doesn't shift
Feed items near the top get obscured by the expanded search card + scrim

Proposed Solutions

Option A: Dynamic spacer based on search state

When searchActive, increase spacer to match expanded card height (~300dp)
Pros: exact spacing. Cons: needs to track card height dynamically.

Option B: Add extra bottom padding to expanded card

Feed items already have their own padding. Just ensure the search card's expanded area doesn't overlap.
Pros: simple. Cons: may not cover all cases.

Acceptance Criteria

Feed items below the search bar are fully visible when search is collapsed
When search expands, feed content is not obscured by the expanded card
Smooth transition when expanding/collapsing

1.3 KiB Raw Blame History