laantungir/seedsigner
1
0
Fork 0
mirror of https://github.com/SeedSigner/seedsigner.git synced 2026-09-14 04:45:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #809 from Chaitanya-Keyal/refactor/remove-bip85-app-num

Browse Source 
[Refactor] Remove bip85 app num
This commit is contained in:
Nick Klockenga
2025-12-15 15:50:18 -05:00
committed by GitHub
parent 53ad05742c fc4662556c
commit 128b892456
2 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/seedsigner/views/seed_views.py
+3 -12
View File
@@ -629,7 +629,7 @@ class SeedOptionsView(View):
return Destination(SeedBackupView, view_args=dict(seed_num=self.seed_num))
elif button_data[selected_menu_num] == self.BIP85_CHILD_SEED:
return Destination(SeedBIP85ApplicationModeView, view_args={"seed_num": self.seed_num})
return Destination(SeedBIP85SelectNumWordsView, view_args={"seed_num": self.seed_num})
elif button_data[selected_menu_num] == self.DISCARD:
return Destination(SeedDiscardView, view_args=dict(seed_num=self.seed_num))
@@ -1120,17 +1120,9 @@ class SeedWordsView(View):
"""****************************************************************************
BIP-85 - Derive child mnemonic (seed) flow
BIP-85 - Derive child mnemonic (seed) flow (Application number 39')
****************************************************************************"""
class SeedBIP85ApplicationModeView(View):
"""
* Ask the user the application type as defined in the BIP-85 spec.
* Currently only Word mode of 12, 24 words (Application number: 39')
* Possible future additions are
* WIF (HDSEED)
* XPRV (BIP-32)
"""
# TODO: Future enhancement to display WIF (HD-SEED) and XPRV (BIP-32)?
class SeedBIP85SelectNumWordsView(View):
WORDS_12 = ButtonOption("12 Words")
WORDS_24 = ButtonOption("24 Words")
@@ -1138,7 +1130,6 @@ class SeedBIP85ApplicationModeView(View):
super().__init__()
self.seed_num = seed_num
self.num_words = 0
self.bip85_app_num = 39 # TODO: Support other Application numbers; TODO: Define this as a constant
def run(self):
tests/screenshot_generator/generator.py
+1 -1
View File
@@ -329,7 +329,7 @@ def generate_screenshots(locale):
ScreenshotConfig(seed_views.SeedWordsWarningView, dict(seed_num=0)),
ScreenshotConfig(seed_views.SeedWordsView, dict(seed_num=0)),
ScreenshotConfig(seed_views.SeedWordsView, dict(seed_num=0, page_index=2), screenshot_name="SeedWordsView_2"),
ScreenshotConfig(seed_views.SeedBIP85ApplicationModeView, dict(seed_num=0)),
ScreenshotConfig(seed_views.SeedBIP85SelectNumWordsView, dict(seed_num=0)),
ScreenshotConfig(seed_views.SeedBIP85SelectChildIndexView, dict(seed_num=0, num_words=24)),
ScreenshotConfig(seed_views.SeedBIP85InvalidChildIndexView, dict(seed_num=0, num_words=12)),
ScreenshotConfig(seed_views.SeedWordsBackupTestPromptView, dict(seed_num=0)),