verify the version check signature before assigning the current version

This commit is contained in:
Craig Raw
2026-08-19 15:35:33 +02:00
parent 571e4c9480
commit dde0985da8
2 changed files with 11 additions and 4 deletions
+1 -1
Submodule drongo updated: 184fd4d755...fcda9f5fc4
@@ -30,9 +30,11 @@ public class VersionCheckService extends ScheduledService<VersionUpdatedEvent> {
protected VersionUpdatedEvent call() {
try {
VersionCheck versionCheck = getVersionCheck();
version = versionCheck.version;
if(isNewer(versionCheck) && verifySignature(versionCheck)) {
return new VersionUpdatedEvent(versionCheck.version);
if(verifySignature(versionCheck)) {
version = versionCheck.version;
if(isNewer(versionCheck)) {
return new VersionUpdatedEvent(versionCheck.version);
}
}
} catch(IOException e) {
log.error("Error retrieving version check file", e);
@@ -57,6 +59,11 @@ public class VersionCheckService extends ScheduledService<VersionUpdatedEvent> {
}
private boolean verifySignature(VersionCheck versionCheck) {
if(versionCheck == null || versionCheck.version == null || versionCheck.signatures == null) {
log.warn("Invalid version check file");
return false;
}
try {
for(String addressString : versionCheck.signatures.keySet()) {
if(!addressString.equals("1LiJx1HQ49L2LzhBwbgwXdHiGodvPg5YaV")) {