The profile Notes tab degraded into gallery-only posts after scrolling past
recent notes, those gallery posts never loaded their media, and there was no
infinite scroll.
- Only surface kind 20/21/22 in the chronological notes feed when they arrive
via the time-bounded, paginated userposts/userposts-more stream. The separate
unbounded usergallery sub (limit 100, no time bound) now feeds galleryPosts
only, so it no longer walls off the feed with far-back gallery events or
poisons oldestNoteTimestamp (which broke loadMoreNotes' until anchor).
- Render gallery kinds with GalleryCard (imeta via Nip68/Nip71, Coil) instead
of PostCard, which only extracts URLs from content text.
- Auto-load more on scroll for the Notes and Replies tabs (RECENCY sort only),
not just the Media tab.
The Transactions page now overlays the home dashboard as a
ModalBottomSheet rather than replacing it. Swipe up 40px on the
recent transactions footer or tap "View all" to open; swipe down
or tap the scrim to dismiss.
- Drawer header: show + circle (solo) or + N pill+chevron (multi) next to avatar for immediate account switcher access; remove redundant chevron beside username
- SplashScreen: accept onCancel param and render frosted Cancel pill when adding an account over an existing session
- Navigation: save previousAccountPubkey before navigating to splash, restore it fully on cancel (account switch + vm reload)
- AuthViewModel: add previousAccountPubkey field to support cancel-and-restore
The trimBlankLines pass was stripping \n\n before NostrProfileSegment and
HashtagSegment, treating them as block-level elements. They are inline —
they share a Text() composable with surrounding text and get no extra Column
spacing — so blank lines before them must be preserved.
Notes whose paragraphs start with a nostr: mention lost all paragraph
spacing on Android as a result.
Removes share/analytics tracking params from URLs as they're rendered:
- utm_* and well-known click-ids (fbclid, gclid, msclkid, igshid, and more) on every host
- YouTube share params (si/feature/pp) scoped to YouTube hosts, covering video, playlist, and channel links
Meaningful params (v, list, t, q, fragments) are preserved, and the URL is returned untouched when nothing is stripped.
A kind-1 note embedding a nostr:naddr reference to a music track (kind
36787) previously fell through to the generic "Unsupported event kind"
placeholder. This adds a dedicated, playable card.
- RichContent.kt: dispatch kind 36787 to a new MusicTrackCard composable
that resolves the addressable event via the existing kind-generic
findAddressableEvent/requestAddressableEvent path and renders artwork,
a MUSIC chip, title, artist, and an author row.
- The play/pause control is wired into the global AudioPlayerController,
so playback survives row recycling and drives the floating mini-player
plus lock-screen/notification controls. Shows a live scrubber while it
owns the player, the static duration tag otherwise.
- EventPersistence.kt: persist kind 36787 so seen tracks resolve
instantly on warm restart.
Ports wisp-ios #378 to Android. Single tracks only; the music-tracks
collection kind (30817) stays on the generic placeholder.
Ports two performance fixes from the dark-wisp-android fork (PRs #34, #23).
EventRepository: maintain a parallel filteredFeed incrementally instead of
re-filtering the entire feedList (up to 5,000 events) on every 50ms publish
window. Membership is decided once at insert time via a single passesFilter()
predicate; the consumer loops now just snapshot the maintained list. The full
O(n) pass survives only in rebuildFilteredFeed() for the rare filter change.
Inserts that don't change the filtered view no longer trigger an emission,
avoiding redundant Compose recompositions during inbound bursts.
NotificationRepository: hoist regex-heavy spam classification out of
synchronized(lock). addEvent now calls warmSpamScore() before the lock, which
applies the same gating as mergeReply and populates SpamAuthorCache; inside the
lock mergeReply only consults the cache. Prevents the main thread from blocking
past the 5s input-dispatch ANR deadline during notification bursts.
Opening a group room or DM whose visible messages contained a media
carousel crashed with:
IllegalStateException: Asking for intrinsic measurements of
SubcomposeLayout layouts is not supported.
The message-bubble content Column used Modifier.width(IntrinsicSize.Max),
which forces an intrinsic-width measurement of every child. One child is
RichContent, which can render MediaCarousel (a BoxWithConstraints +
HorizontalPager). Those are SubcomposeLayout-based and cannot answer
intrinsic queries, so the measure pass threw.
Remove IntrinsicSize.Max from the group and DM bubble columns and let
the bubble hug its content. The received-message header row no longer
fills width (which would otherwise balloon every bubble to max width
without the intrinsic sizing); the sender name uses widthIn(max) so long
names still ellipsize.
eventRelays stored per-event relay URLs in plain LinkedHashSet instances
(mutableSetOf). addEventRelay mutates these live sets from relay IO threads
as events stream in, while getEventRelays returns the same live set that UI
coroutines and getRelayHintsForEvents iterate on the Main dispatcher. A
concurrent add mid-iteration threw ConcurrentModificationException
(LinkedHashMap$LinkedKeyIterator.next).
Use ConcurrentHashMap.newKeySet(), whose iterator is weakly consistent, so
concurrent adds during iteration no longer throw. This matches the existing
pattern already used for the sibling repostAuthors cache.
The "Uploading…" label was crammed into the compose toolbar's icon row
alongside six icon buttons, leaving no horizontal space — so the text
wrapped to three lines ("Uplo / ading / …"). This pulls the spinner +
label out of the icon row onto a dedicated line below it, wrapped in a
rounded surfaceVariant capsule with maxLines = 1 so it can never wrap.
It animates in/out with the upload lifecycle.
Mirrors barrydeen/dark-wisp-android#38.
InlineVideoPlayer and InlineVideoPlayerWithFullscreen created a fully
prepared ExoPlayer per video URL the moment it entered composition,
with no cap or visibility gating. A note carrying many video URLs
(such as a 155-video note seen in the wild) instantly spawned a
player per URL -- 156 players / 487 player threads measured upstream,
exhausting hardware codec instances (~16-32 device-wide) and memory
until input dispatch timed out (ANR).
The player now only exists while its video is near the viewport:
created when >50% visible with autoplay on, or on tap (which starts
playback immediately); released with its position remembered once the
video scrolls fully off-screen. Until then the slot renders the
uploader-provided NIP-92 imeta "image" preview frame, falling back
to the existing thumbhash/blurhash painter. parseImetaTags now parses
the "image" entry, and MediaCarousel video tiles use it too instead
of a blank box when no thumbhash/blurhash is present.
Port of barrydeen/dark-wisp-android#31.
NotificationRepository.addEvent ran NSpamClassifier.score() inside
synchronized(lock) via mergeKind1 -> mergeReply. Feature extraction
runs several regex passes over up to ten notes per author; doing it
under the lock stalls every caller -- including main-thread callers
like getAllPostCardEventIds() and markRead -- past the 5s
input-dispatch deadline.
Fix: warmSpamScore(event) runs before the lock, computes the score
under the same spamFilterEnabled/isFollowing/safelist/reply-target
guards, and caches it in SpamAuthorCache (LruCache-backed, thread-
safe). mergeReply now only consults the cache.
Port of barrydeen/dark-wisp-android#23.
Non-debuggable + R8-minified like release (initWith(release)), but
debug-signed so anyone can install it without the release keystore.
applicationIdSuffix ".staging" and app name "Wisp Staging" let it
install alongside debug and release builds.
debuggable=true makes ART ignore the baseline profile and run
JIT-only with deoptimization support, which cripples the per-event
hot path (JSON parse, hex decode, SHA-256, JNI Schnorr verify per
relay event) -- so debug builds can't be used to judge real
performance.
Port of barrydeen/dark-wisp-android#24.
A self-payment surfaces as two transaction records sharing one payment
hash — one outgoing, one incoming. Port the iOS WalletStore.dedupTransactions
hardening so they render correctly:
- Add dedupTransactions(): drop exact (paymentHash, type) repeats the
backend returns, and sort newest-first with the incoming "received" leg
above its outgoing "sent" leg on a timestamp tie. Apply on initial load,
re-enrich, and load-more.
- Key the transaction LazyColumn by "paymentHash|type" so the two legs of a
self-send keep distinct identities and both render (mirrors iOS
WalletTransaction.id).
Six wallet string keys (wallet_connect_wallet, wallet_choose_how,
wallet_create_new, wallet_create_description, wallet_nwc_description,
wallet_spark) were renamed in the default locale but left behind in
10 translation files, causing 60 ExtraTranslation lint errors that
failed lintVitalRelease.
The WoT filter was already silently dropping events at EventRepository
ingestion and in NotificationRepository, but thread replies bypassed
both paths — ThreadViewModel keeps its own threadEvents map seeded via
cacheEvent() and getCachedThreadEvents(), neither of which checks WoT.
Apply isWotFiltered in rebuildTree() alongside the existing block /
mute / spam filters. The root note is always shown (user explicitly
navigated to it); replies from authors outside the qualified network
are silently dropped, matching how WoT behaves in the feed and
notifications.
Replaces the orange numpad-style Receive screen with a form layout matching
iOS ReceiveInvoiceSheet:
- AMOUNT label + single text field (numeric keyboard, "0" placeholder,
"sats" or fiat suffix). In fiat mode shows the live sats conversion
below the field.
- NOTE (OPTIONAL) label + single-line text field with "For coffee, etc."
placeholder — plumbed through generateInvoice(amountSats, description)
so the note is embedded in the BOLT11 invoice description.
- Create invoice full-width button; disabled (gray) until the amount
parses to > 0 sats.
- Invoice / Lightning Address segmented control at the top, shown only
when the user has a Spark lightning address. Switching to the address
tab renders the address QR + Copy / Share row inline (no nav churn).
Touches:
- WalletScreen.kt: rewrites ReceiveAmountContent; adds ReceiveAddressBlock.
Uses BasicTextField for the hero amount field (custom placeholder
inside a rounded surface) and a second BasicTextField for the note.
- WalletViewModel.kt: generateInvoice now takes (amountSats, description);
adds setReceiveAmount(value) for the new text-input path. The existing
digit-by-digit updateReceiveAmount / receiveAmountBackspace stay
untouched (still used by Send numpad).
- strings.xml: new English strings for the labels / placeholders / CTA.
Translations to follow.
Tested on device.
Ports iOS commit #6 from feat/one-tap-zap. Replaces the multi-layer
Canvas bolt animation that was smearing the silhouette at scale
peaks. New approach: always-white silhouette + three stacked
zap-color shadows underneath, driven by a single sin-eased
oscillator.
Math (period 0.9s):
sine ∈ [-1, 1]
phase ∈ [0, 1] = (sine + 1) / 2
iconScale = 1.0 + 0.10 * sine (0.90 → 1.10)
verticalOffset = -0.5 * sine (±0.5dp centered on baseline)
Shadow layers (Canvas strokes — drawn outer → inner so the white
core sits on top):
outer — radius 8 + 6*phase dp, α = 0.30 + 0.50*phase
medium — radius 4 + 3*phase dp, α = 0.55 + 0.45*phase
inner — radius 1.5dp constant, α = 0.95
core — solid white silhouette, untinted
Vertical motion held to ±0.5dp so the icon doesn't lift off the
action-bar baseline and misalign with neighbouring glyphs. The
white IS the luminous core; the warm halos do the heat work.
LinearEasing on the sineAngle (not FastOutSlowInEasing) — the
sine function itself supplies the easing curve. Wrapping with
another easing would double-stack and visibly stutter.
iOS doesn't surface a per-relay backup status display in the wallet
settings screen, and the section is overkill for the Android side too —
the majority of users start with the default Spark wallet (which never
shows the relay-backup affordance at all, because the nsec is the
canonical backup), and the remaining minority on non-default Spark
wallets get the "Backup to Nostr Relays" button alongside the Recovery
Phrase row without needing a per-relay status card to interpret.
Removes the entire status block: the "Relay Backup Status" header +
refresh icon, the relay-URL + green/grey dot card, the "Delete Relay
Backup" TextButton + status messages, and the confirmation dialog.
The "Backup to Nostr Relays" button stays — non-default wallets can
still push the encrypted backup to relays, we just don't surface the
fine-grained per-relay state inline.
WalletViewModel plumbing (`relayBackupStatuses`, `relayBackupCheckLoading`,
`checkRelayBackupStatuses()`, `deleteRelayBackup()`) is left in place
deliberately. The status check + delete actions are still wired through
the WalletScreen parameter list so other entry points (or a future
debug-only view) can use them, and ripping the ViewModel state out
would balloon this diff into a refactor.
The default Spark wallet derives from the user's nsec, so the nsec
already serves as the cross-device backup — the "Backup to Nostr
Relays" affordance is redundant and noisy alongside the equivalent
nsec-based recovery path. Recovery Phrase view is unchanged.
Hides the relay backup button + status section for default wallets;
non-default wallets keep both, since they have no nsec-derived
fallback.
Barry Deen
The Daniel
Letdown2491