Merge #109

109: Misc cleanups r=msfjarvis a=msfjarvis

bors r+
🤖

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>

app/src/main/java/dev/msfjarvis/lobsters/data/repo/LobstersRepository.kt

@@ -21,10 +21,6 @@ class LobstersRepository constructor(
     return savedPostsCache.containsKey(postId)
   }
 
-  fun getPostFromCache(postId: String): LobstersPost? {
-    return savedPostsCache[postId]
-  }
-
   fun getAllPostsFromCache(): List<LobstersPost> {
     return savedPostsCache.values.toList()
   }
@@ -43,10 +39,6 @@ class LobstersRepository constructor(
     _isCacheReady.value = true
   }
 
-  private suspend fun getPost(postId: String): LobstersPost? = withContext(Dispatchers.IO) {
-    return@withContext lobstersDatabase.postQueries.selectPost(postId).executeAsOneOrNull()
-  }
-
   private suspend fun getAllPosts(): List<LobstersPost> = withContext(Dispatchers.IO) {
     return@withContext lobstersDatabase.postQueries.selectAllPosts().executeAsList()
   }

buildSrc/build.gradle.kts

@@ -29,10 +29,10 @@ gradlePlugin {
 }
 
 dependencies {
-  implementation(Plugins.androidGradlePlugin)
-  implementation(Plugins.androidGradlePlugin_lintModel)
-  implementation(Plugins.daggerGradlePlugin)
+  implementation(Plugins.android)
+  implementation(Plugins.hilt)
   implementation(Plugins.jsemver)
-  implementation(Plugins.kotlinGradlePlugin)
-  implementation(Plugins.sqldelightGradlePlugin)
+  implementation(Plugins.lintModel)
+  implementation(Plugins.kotlin)
+  implementation(Plugins.sqldelight)
 }

buildSrc/src/main/java/Dependencies.kt

@@ -6,13 +6,12 @@
 private const val DAGGER_HILT_VERSION = "2.32-alpha"
 
 object Plugins {
-  const val androidGradlePlugin = "com.android.tools.build:gradle:7.0.0-alpha06"
-  const val androidGradlePlugin_lintModel = "com.android.tools.lint:lint-model:30.0.0-alpha06"
-  const val daggerGradlePlugin =
-    "com.google.dagger:hilt-android-gradle-plugin:${DAGGER_HILT_VERSION}"
-  const val kotlinGradlePlugin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.30"
+  const val android = "com.android.tools.build:gradle:7.0.0-alpha06"
+  const val lintModel = "com.android.tools.lint:lint-model:30.0.0-alpha06"
+  const val hilt = "com.google.dagger:hilt-android-gradle-plugin:${DAGGER_HILT_VERSION}"
+  const val kotlin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.30"
   const val jsemver = "com.github.zafarkhaja:java-semver:0.9.0"
-  const val sqldelightGradlePlugin = "com.squareup.sqldelight:gradle-plugin:1.4.4"
+  const val sqldelight = "com.squareup.sqldelight:gradle-plugin:1.4.4"
 }
 
 object Dependencies {