Commit Graph
856 Commits
Author SHA1 Message Date
Harsh Shandilya 34cfeb3250 build: bump Dagger to 2.36
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-26 09:20:03 +05:30
Harsh Shandilya 6bbcb979c3 Revert "build: upgrade all dependencies"
This reverts commit ffd46f1d29.
2021-05-23 18:53:03 +05:30
Harsh Shandilya 5ef621d26a Revert "github: switch snapshots for debug builds"
This reverts commit d7c1c6bca6.
2021-05-23 18:53:02 +05:30
d5bc33a280 Merge #254
254: Upgrade all dependencies r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-22 10:36:30 +00:00
Harsh Shandilya d7c1c6bca6 github: switch snapshots for debug builds
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-22 16:05:50 +05:30
Harsh Shandilya 4b968f3bed app: customize app name for debug builds
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-22 16:05:50 +05:30
Harsh Shandilya ffd46f1d29 build: upgrade all dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-22 16:05:50 +05:30
70b4edcbb7 Merge #252
252: Handle lobste.rs deeplinks in the app r=msfjarvis a=Skrilltrax

Deeplink handling in Android is _interesting_.

Here's what is happening atm, 

```
<data
	android:ssp="//lobste.rs"
    android:scheme="https" />
```
Handles `https://lobste.rs`. We are using `ssp` here because using `host` without path `/` will match with all of the possible paths e.g, `https://lobste.rs/login` which we do not want.


```
<data
	android:host="lobste.rs"
    android:scheme="https"
    android:path="/"/>
```
Handles `https://lobste.rs/`


```
<data
	android:host="lobste.rs"
    android:scheme="https"
    android:pathPrefix="/recent" />
```
Handles `https://lobste.rs/recent` and `https://lobste.rs/recent/`


```
<data
	android:host="lobste.rs"
    android:scheme="https"
    android:pathPattern="/s/......" />
```
Handles `https://lobste.rs/nr9kzv`.

```
<data
	android:host="lobste.rs"
    android:scheme="https"
    android:pathPattern="/s/....../" />
```
Handles `https://lobste.rs/nr9kzv/`.

```
<data
	android:host="lobste.rs"
    android:scheme="https"
    android:pathPattern="/s/....../...*" />
```
Handles everything after `https://lobste.rs/s/nr9kzv/` except for a case where the `postTitle` is one character long. This one character string is used for the reply URL.

Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2021-05-16 17:28:27 +00:00
Aditya WasanandHarsh Shandilya 96d8bfdb73 HACK: app: add workaround to prevent deeplinking comment replies back to the app
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-05-16 22:52:23 +05:30
Aditya WasanandHarsh Shandilya bdb1c8ef1b manifest: remove comments pathPattern
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-05-16 22:52:00 +05:30
Aditya WasanandHarsh Shandilya ce66536dde app: initial deeplinks handling
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-05-16 22:51:59 +05:30
829e1906d6 Merge #250
250: Bump Gradle to 7.0.2 r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-16 06:07:44 +00:00
Harsh Shandilya 8f1153b05b Bump Gradle
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-16 11:37:08 +05:30
92db1a4ce5 Merge #249
249: Remove duplicate UrlLauncher from desktop r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-12 23:40:27 +00:00
Harsh Shandilya 4ca4fe81f0 desktop: use the UrlLauncher from common
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-13 04:20:48 +05:30
d00cf77d1d Merge #248
248: Update JB Compose r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-12 17:06:31 +00:00
Harsh Shandilya 4d6eb9ff1d gradle: bump JB Compose to 0.4.0-build190
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-12 22:32:52 +05:30
022de71c62 Merge #247
247: Bump Gradle to 7.0.1 r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-10 18:52:50 +00:00
Harsh Shandilya 0fde488dde gradle: bump to 7.0.1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-11 00:22:11 +05:30
76c758d027 Merge #246
246: Bump deps and remove swipe refreshing for now r=msfjarvis a=msfjarvis

Swipe refresh is causing crashes for me deep in the bowels of NestedScroll

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-08 19:33:48 +00:00
Harsh Shandilya b847feae22 app: remove swipe refresh
This is causing crashes

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-09 00:49:56 +05:30
Harsh Shandilya 5a4efa33cf gradle: bump accompanist and activity-compose
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-09 00:30:49 +05:30
fb45ed99c2 Merge #245
245: Enable cacheability of internal AGP tasks r=msfjarvis a=msfjarvis

Taken from https://issuetracker.google.com/issues/141301405

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-06 16:28:07 +00:00
Harsh Shandilya 9967a534bd gradle: enable cacheability of internal AGP tasks
https://issuetracker.google.com/issues/141301405

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-06 21:56:45 +05:30
9745243cda Merge #244
244: AndroidX update day r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-05 19:39:10 +00:00
Harsh Shandilya ab10e04c72 gradle: bump deps
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-06 01:08:29 +05:30
d9ebe79ec7 Merge #243
243: Fix target SDK r=msfjarvis a=msfjarvis

Copypasta fail in #238
bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-05 08:04:20 +00:00
Harsh Shandilya e2774e48cd Set target SDK back to 30
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-05 13:33:18 +05:30
a6c476a97a Merge #242
242: Remove Shot entirely r=msfjarvis a=msfjarvis

It hasn't worked in a month and the dependencies are just dead weight

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-04 21:28:34 +00:00
Harsh Shandilya a4313bc401 Completely remove screenshot tests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-05 02:58:04 +05:30
Harsh Shandilya e8b313605f app: directly use AndroidX dependencies
The JB Compose Gradle plugin will inject substitution rules automatically

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-05 02:36:55 +05:30
c1a56e59dd Merge #241
241: Bump JB Compose r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-04 20:39:07 +00:00
Harsh Shandilya e909f6e2bd build: bump JB Compose
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-05 02:08:26 +05:30
8becbb7f53 Merge #239
239: Add FAB animation  r=msfjarvis a=Skrilltrax



Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-04 06:37:18 +00:00
Harsh Shandilya 81b4da3584 Constify scroll delta and animation duration
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-05-04 12:06:47 +05:30
Aditya Wasan ea6f633d9b app: add hide animation to comment screen fab
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-05-04 11:13:13 +05:30
09dc4fc87b Merge #238
238: Bump to AGP 7.0.0-alpha15 r=msfjarvis a=msfjarvis

Also adapts the snapshot deployment scripts for removal of variant output API.

bors r+


Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-30 04:47:32 +00:00
Harsh Shandilya 85a7d0df84 scripts/deploy-snapshot: adapt for removal of variant output API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-30 10:10:24 +05:30
Harsh Shandilya a602a22eb0 Bump AGP to 7.0.0-alpha15
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-30 10:08:19 +05:30
7a9cc78264 Merge #237
237: Bump Dagger r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-28 02:47:30 +00:00
Harsh Shandilya 8152f4db96 build: bump Dagger Hilt
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-28 08:16:51 +05:30
f316a6ebaa Merge #236
236: Bump JB Compose to 0.4.0-build185 r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-27 04:53:01 +00:00
Harsh Shandilya ab1a9daefb build: bump JB Compose to 0.4.0-build185
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-27 10:22:13 +05:30
bbf3261815 Merge #227
227: Track comment parents via colored lines r=msfjarvis a=msfjarvis

Work towards #204

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2021-04-26 10:37:01 +00:00
Aditya WasanandHarsh Shandilya 45715a6c45 fix: re-use colors when comment depth becomes greater than the number of colors available
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-04-26 16:06:02 +05:30
Aditya WasanandHarsh Shandilya 635b508795 fix: set content size to be the min size of the container
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-04-26 16:05:02 +05:30
Harsh Shandilya 24f31f6fa2 Initial parent tracking implementation
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-26 16:04:59 +05:30
73708a52d9 Merge #235
235: Use bors to manage spotless check r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-24 23:16:10 +00:00
Harsh Shandilya ef37928981 github: move stylecheck to bors
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-25 04:45:30 +05:30
8f2fe76706 Merge #234
234: Integrate Spotless and check codestyle in CI r=msfjarvis a=msfjarvis

bors r+

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-04-24 23:08:17 +00:00