Commit Graph
100 Commits
Author SHA1 Message Date
Harsh Shandilya 1abbd8baba common/app: migrate all string usages to common Strings API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:52 +05:30
Harsh Shandilya cad53dcce5 common: remove old string API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:51 +05:30
Harsh Shandilya 4016c22289 app: switch to extension API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:51 +05:30
Harsh Shandilya 56fd18be75 common: attempt extension backed string API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 11:56:51 +05:30
Harsh Shandilya 00c1977f87 common/app: rename StringEnum to Strings
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:43:47 +05:30
Harsh Shandilya b19a9267f6 common: link bug in code
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:38:44 +05:30
Harsh Shandilya 5783210873 app: add sun.misc.Unsafe to proguard rules
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:34:18 +05:30
Harsh Shandilya f242ffb2af common: cleanup Gradle build
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-24 10:30:45 +05:30
Harsh Shandilya 5f227b2327 build: update deps
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 22:02:12 +05:30
Harsh Shandilya b233129c32 common: include androidMain resources directory
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 21:15:37 +05:30
Harsh Shandilya 08e8993101 Add tests for LobstersTopAppBar
(cherry picked from commit eee0737a1c)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:45:54 +05:30
Harsh Shandilya 3be1d2ad87 Wire in sorting preference awareness
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:42:14 +05:30
Harsh Shandilya 1408bee041 Wire in ability to toggle sorting order
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:41:58 +05:30
Harsh Shandilya 9bf5ee90ef Introduce and integrate ClawPreferences
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-23 17:40:30 +05:30
Harsh Shandilya 9e3f718ab9 Add DataStore dependency and set up injection
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-22 23:26:52 +05:30
Harsh Shandilya ae1018f8c5 build: update AGP
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-22 22:19:05 +05:30
Harsh Shandilya 2b68bd82a4 LobstersItem: break avatar URL for test post
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-22 00:36:46 +05:30
Harsh Shandilya 88f44bd63b app: update screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-21 22:57:28 +05:30
Harsh Shandilya ced3aa44f1 Add tests for list of posts
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-21 22:57:12 +05:30
Harsh Shandilya 6f1a488b92 Rewrite LobstersItem
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-21 22:56:01 +05:30
Harsh Shandilya 88a309712d scripts/boot_emulator: dynamically set AVD name
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-20 18:41:14 +05:30
Harsh Shandilya f37682c154 scripts: import cleanups from APS
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-20 18:13:05 +05:30
Harsh Shandilya ce8d9f09fa app: update screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 16:26:07 +05:30
Harsh Shandilya 82707f8347 LobstersItem: tweak paddings
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 16:24:05 +05:30
Harsh Shandilya eae231722f LobstersItem: tweak paddings
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 16:02:40 +05:30
Harsh Shandilya f269c0ae08 app: rename LobstersItem parameters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 15:18:22 +05:30
Harsh Shandilya 840361707a LobstersItem: add a dedicated comments button
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 15:17:32 +05:30
Harsh Shandilya dbab82c533 LobstersItem: adjust row weightage
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 15:04:40 +05:30
Harsh Shandilya fa605f5416 LobstersItem: split details and button to separate composables
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 14:57:57 +05:30
Harsh Shandilya cfc2680786 build: add missing R8 rules and sort
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-19 02:52:59 +05:30
Harsh Shandilya 420f792290 all: switch to kotlin.test for unit testing
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-18 23:56:28 +05:30
Harsh Shandilya 733fb5d96c common: move AndroidManifest to the correct source set
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-18 21:54:49 +05:30
Harsh Shandilya 0388010c8b build: remove unused dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-16 18:33:24 +05:30
Harsh Shandilya ab6816be62 build: update to AGP 7.0.0-alpha10
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-16 18:31:43 +05:30
Harsh Shandilya ede879c550 github: restructure CI test setup
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-16 15:26:58 +05:30
Harsh Shandilya 8bf42fa46a Disable KMP warning
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-15 21:57:40 +05:30
Harsh Shandilya 879cb951a0 app: don't attempt to scroll if posts are loading
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-15 21:57:19 +05:30
Harsh Shandilya f5c3a950bf common: make UrlLauncher use expect/actual
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-15 00:00:37 +05:30
Harsh Shandilya 3021f96465 common: cleanup duplicated Gradle configs
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-14 23:47:05 +05:30
Harsh Shandilya 117c063f78 desktop: fix kotlin directory
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-14 23:39:21 +05:30
Harsh Shandilya c5fafba7b5 desktop: sort everything under packages
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-14 20:01:45 +05:30
Harsh Shandilya 704e59afdf desktop: integrate with API
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-14 19:57:10 +05:30
Harsh Shandilya be6e0c9498 desktop: initialize subproject
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-14 19:23:40 +05:30
Harsh Shandilya 697e806dd8 app: switch to PullToRefresh
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-13 02:44:12 +05:30
Harsh Shandilya a28d5085bb app: remove LobstersTopAppBar
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-11 17:59:47 +05:30
Harsh Shandilya ae1770e4ac Add a basic HACKING.md
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-11 16:57:31 +05:30
Harsh Shandilya a5a710cbb1 scripts: add boot_emulator.sh
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-11 16:38:25 +05:30
Harsh Shandilya 3d7172d664 Switch to Pixel XL profile
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-11 10:40:01 +05:30
Harsh Shandilya 68431d4a25 github: fix CI workflow to include screenshot tests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-11 10:28:41 +05:30
Harsh Shandilya aa6256b2d4 build: update all dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-11 10:05:51 +05:30
Harsh Shandilya 7709665538 app: update screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-10 14:51:15 +05:30
Harsh Shandilya 00d15f5475 LobstersItem: improve TagRow reflow behavior
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-10 14:47:02 +05:30
Harsh Shandilya c048ecf9cf Supress false-positive Lint issue
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-10 09:48:01 +05:30
Harsh Shandilya d5e51366e9 build: upgrade to AGP 7.0.0-alpha09
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-10 09:30:42 +05:30
Harsh Shandilya 008c2171ff Brighten up secondary color for dark theme
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 23:46:04 +05:30
Harsh Shandilya 81bf27c13e Slightly improve header test
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 20:16:13 +05:30
Harsh Shandilya 8c8af56e67 app: update test screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 20:14:28 +05:30
Harsh Shandilya 418d1b22d6 build: set applicationIdSuffix for debug builds
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 20:13:45 +05:30
Harsh Shandilya 607e93e180 app: switch to FlowLayout for TagRow
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 19:53:15 +05:30
Harsh Shandilya d42adbf85d build: update shot
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 11:44:33 +05:30
Harsh Shandilya 87e0ede2be app: update screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 10:35:07 +05:30
Harsh Shandilya 330c3a6d22 LobstersItem: improve clickability of save icon
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-09 10:32:34 +05:30
Harsh Shandilya 08c511f854 posts: use a shimmering animation for loading posts
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-08 16:22:39 +05:30
Harsh Shandilya 5718628d72 app: refresh UI test screenshots
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-06 01:08:05 +05:30
Harsh Shandilya 0ca4aadfb5 all: remove unneeded manifests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-06 00:58:35 +05:30
Harsh Shandilya 8e2d8fb89d build: upgrade to Shot 5.10.0
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-06 00:32:00 +05:30
Harsh Shandilya ce34b1173d Header: tweak design a bit
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-06 00:09:31 +05:30
Harsh Shandilya 97ac1033eb gitignore: add deployment target XML
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-05 13:35:21 +05:30
Harsh Shandilya eee0737a1c Add tests for LobstersTopAppBar
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-05 13:35:17 +05:30
Harsh ShandilyaandAditya Wasan 83af1e1c53 Don't inject paging source
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-05 13:35:16 +05:30
Harsh Shandilya 4585757ac2 app: add support for refreshing hottest posts list
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-05 13:35:16 +05:30
Harsh Shandilya f80c3a0090 github: update emulator action
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-05 11:14:09 +05:30
Harsh Shandilya 3a75dd75b5 build: upgrade coroutines to 1.4.3
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-04 09:34:00 +05:30
Harsh Shandilya f7c6330910 LobstersApp: lower coroutine scope further in the view tree
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-02 09:08:17 +05:30
Harsh Shandilya 4423d0f17f build: update MoshiX
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-03-02 08:02:27 +05:30
Harsh Shandilya 777ee3d408 github: add ci-gradle.properties
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:59:00 +05:30
Harsh Shandilya e440ac088b idea: regular churn
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:47:41 +05:30
Harsh Shandilya 7e7609ca1f build: force Moshi to latest version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:47:41 +05:30
Harsh Shandilya fb2005fd83 all: switch to moshi-ksp
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:47:41 +05:30
Harsh Shandilya 7b87792d8a app: switch to new models
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:47:40 +05:30
Harsh Shandilya 9d684536a1 database: remove LobstersPost table
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:47:40 +05:30
Harsh Shandilya 75888c5ba6 database: add SavedPost table and switch tests to it
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:47:39 +05:30
Harsh Shandilya f76628574a api: separate API response model from database model
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:22:23 +05:30
Harsh Shandilya b577ab01ae themes: set system bars colors to black
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 15:42:32 +05:30
Harsh Shandilya cf6ff4c315 manifest: turn on full backups
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 15:00:53 +05:30
Harsh Shandilya f15f609832 Add regression test for month header
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 14:52:24 +05:30
Harsh Shandilya 582fb5ba93 header: fix unwanted transparency
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 14:15:37 +05:30
Harsh Shandilya 4418404a71 github: use google_apis variant of emulator image
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 23:37:18 +05:30
Harsh Shandilya 8427cc52d8 github: remove unnecessary animation control
The action does it for us.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 23:29:28 +05:30
Harsh Shandilya 6c523d006b build: accompanist 0.6.1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 23:19:19 +05:30
Harsh Shandilya f5bc2ebb59 Initial draft of screenshot testing setup
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 19:01:58 +05:30
Harsh Shandilya 160ebcf7f5 build: add KotlinX Bintray repository
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:19:38 +05:30
Harsh Shandilya 8638868fb7 build: remove JCenter repository
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:09:36 +05:30
Harsh Shandilya c2ee9032b9 build: remove ConstraintLayout dependency
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:02:16 +05:30
Harsh Shandilya ebc75bddca LobstersItem: reimplement with Rows and Columns
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:02:06 +05:30
Harsh Shandilya 639f814ef8 Add sticky headers to saved posts
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 17:33:42 +05:30
Harsh Shandilya f3e632078a build: upgrade to Hilt 2.33-beta
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-26 09:53:32 +05:30
Harsh Shandilya 5d74c6787f github: disable unneeded emulator runner
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 19:55:33 +05:30
Harsh Shandilya 095cb8d3a1 Remove BottomNavigationLayoutTest
Boss man Jim Sproch recommends we use screenshot testing rather than asserting on nodes
since they can change under us at any time as more optimisations come into play.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 19:54:43 +05:30
Harsh Shandilya f745ff3e91 github: don't run tests on merge to dev and use macOS runner
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 09:58:18 +05:30