Commit Graph
100 Commits
Author SHA1 Message Date
Harsh Shandilya f76628574a api: separate API response model from database model
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 20:22:23 +05:30
Harsh Shandilya b577ab01ae themes: set system bars colors to black
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 15:42:32 +05:30
Harsh Shandilya cf6ff4c315 manifest: turn on full backups
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 15:00:53 +05:30
Harsh Shandilya f15f609832 Add regression test for month header
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 14:52:24 +05:30
Harsh Shandilya 582fb5ba93 header: fix unwanted transparency
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-28 14:15:37 +05:30
Harsh Shandilya 4418404a71 github: use google_apis variant of emulator image
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 23:37:18 +05:30
Harsh Shandilya 8427cc52d8 github: remove unnecessary animation control
The action does it for us.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 23:29:28 +05:30
Harsh Shandilya 6c523d006b build: accompanist 0.6.1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 23:19:19 +05:30
Harsh Shandilya f5bc2ebb59 Initial draft of screenshot testing setup
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 19:01:58 +05:30
Harsh Shandilya 160ebcf7f5 build: add KotlinX Bintray repository
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:19:38 +05:30
Harsh Shandilya 8638868fb7 build: remove JCenter repository
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:09:36 +05:30
Harsh Shandilya c2ee9032b9 build: remove ConstraintLayout dependency
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:02:16 +05:30
Harsh Shandilya ebc75bddca LobstersItem: reimplement with Rows and Columns
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 18:02:06 +05:30
Harsh Shandilya 639f814ef8 Add sticky headers to saved posts
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-27 17:33:42 +05:30
Harsh Shandilya f3e632078a build: upgrade to Hilt 2.33-beta
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-26 09:53:32 +05:30
Harsh Shandilya 5d74c6787f github: disable unneeded emulator runner
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 19:55:33 +05:30
Harsh Shandilya 095cb8d3a1 Remove BottomNavigationLayoutTest
Boss man Jim Sproch recommends we use screenshot testing rather than asserting on nodes
since they can change under us at any time as more optimisations come into play.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 19:54:43 +05:30
Harsh Shandilya f745ff3e91 github: don't run tests on merge to dev and use macOS runner
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 09:58:18 +05:30
Harsh Shandilya 8b976cee3c BottomNavigationLayoutTest: remove unneeded assertExists
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-25 09:57:08 +05:30
Harsh Shandilya 6e77a5e94b build: update to Compose 1.0.0-beta01
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-24 23:52:17 +05:30
Harsh Shandilya c8052be29a build: upgrade to AGP 7.0.0-alpha08
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-24 23:52:16 +05:30
Harsh Shandilya b977113e34 api/database: switch to kotlin JVM plugin
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-23 17:44:42 +05:30
Harsh Shandilya 027e3410d8 all: move all Hilt processing to app module
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-23 17:44:41 +05:30
Harsh Shandilya 75a83606f2 build: upgrade to Gradle 6.8.3
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-23 17:38:14 +05:30
Harsh Shandilya 859ab94104 README: clarify unofficial nature
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-23 13:17:27 +05:30
Harsh Shandilya c4514ad4cd github: only run CI once approved
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-23 12:19:39 +05:30
Harsh Shandilya 875e4ea32c Revert "LobstersApp: replace with a BackgroundScaffold"
This reverts commit be58017cac.
2021-02-20 13:58:05 +05:30
Harsh Shandilya 72d51d5c52 Revert "app: remove now uneeded navigation code"
This reverts commit 41c64f4b02.
2021-02-20 13:58:01 +05:30
Harsh Shandilya 7bb8c5b8f4 build: update AGP, MoshiX and JUnit
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-19 10:04:05 +05:30
Harsh Shandilya 5c39c481b7 app: add proguard rules for release builds
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-17 00:25:41 +05:30
Harsh Shandilya 66a2e9ef69 BaseProjectConfig: properly register clean task
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-17 00:15:19 +05:30
Harsh Shandilya 41c64f4b02 app: remove now uneeded navigation code
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-17 00:11:48 +05:30
Harsh Shandilya be58017cac LobstersApp: replace with a BackgroundScaffold
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-17 00:10:28 +05:30
Harsh Shandilya d82228483d main: split out LobstersApp
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-16 23:54:16 +05:30
Harsh Shandilya 5815afafb7 gradle: shorten project name
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-14 18:42:29 +05:30
Harsh Shandilya f30fd72778 app: remove unused methods
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-14 18:23:26 +05:30
Harsh Shandilya b455724b1c build: cleanup Plugin declarations
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-14 18:23:26 +05:30
Harsh Shandilya 9bf7a97e55 buildSrc: codestyle fixups
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-14 17:47:02 +05:30
Harsh Shandilya 7afff19fce build: update AGP
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-14 17:33:30 +05:30
Harsh ShandilyaandAditya Wasan 91cfb0b2d2 github: prep for running instrumentation tests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-12 11:33:47 +05:30
Harsh ShandilyaandAditya Wasan 7da2cfd456 buildSrc: exclude duplicate license file from packaging
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-12 11:33:37 +05:30
Harsh ShandilyaandAditya Wasan 97eaf20dbc build(app): add compose testing dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-12 11:33:23 +05:30
Harsh Shandilya aff52e7d5f all: reformat
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-11 16:46:50 +05:30
Harsh Shandilya 98866ee407 Simplify getDestinationFromRoute
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-11 16:45:50 +05:30
Harsh Shandilya 885c2a5865 build: upgrade to Compose 1.0.0-alpha12
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-11 16:28:34 +05:30
Harsh Shandilya 5fef8a4d51 build: replace JCenter with MavenCentral and drop JitPack
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-11 16:28:10 +05:30
Harsh Shandilya c0e0e53ee7 build: upgrade to Dagger 2.32
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-09 15:08:22 +05:30
Harsh Shandilya 2029ceeee0 build: upgrade to Dagger 2.32
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-09 15:08:01 +05:30
Harsh Shandilya b5a4787424 idea: add icons
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:21:58 +05:30
Harsh Shandilya 8f53a39f63 build: upgrade kotlin
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:45 +05:30
Harsh Shandilya 020976e257 build: update remaining dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:44 +05:30
Harsh Shandilya cdfa20b9a7 build: upgrade to Compose alpha11
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:43 +05:30
Harsh Shandilya b87e242de2 build: remove gradle-versions-plugin
I use a Gradle init script for this now

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 13:13:02 +05:30
Harsh Shandilya df1db3d0ff buildSrc: move plugin dependencies to Dependencies.kt
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-01 18:43:52 +05:30
Harsh Shandilya 2a4c58a680 buildSrc: conditionally configure Dagger and disable kapt in tests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-01 18:32:47 +05:30
Harsh Shandilya 0c1b20d3e7 buildSrc: remove unneeded AGP builder dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-01 18:25:30 +05:30
Harsh Shandilya d4ecf97436 Correctly set -Xopt-in=kotlin.RequiresOptIn on all modules
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-31 15:06:36 +05:30
Harsh Shandilya 49d9ceb73a app: cleanups
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-31 15:06:18 +05:30
Harsh Shandilya c835a59cbf proguard(app): disable ProGuard inlining optimisations
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:16 +05:30
Harsh Shandilya 32bfdde04e Revert "all: switch to moshi-kotlin and fix tests"
This reverts commit da25dd2ed9bea50691b889e093ff896fea598b1a.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:15 +05:30
Harsh Shandilya 4f9d0c09ef Make is_saved nullable
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:14 +05:30
Harsh Shandilya 740d9e432a all: switch to moshi-kotlin and fix tests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:14 +05:30
Harsh Shandilya bca96ae215 app: switch to SQLDelight version of LobstersPost
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:13 +05:30
Harsh Shandilya b18de72bdd all: move model classes to database, rename model to api
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:09 +05:30
Harsh Shandilya f17becff10 app: remove Room
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:07 +05:30
Harsh Shandilya 042b8f60d5 database: generate skeleton project
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:49:43 +05:30
Harsh Shandilya 33b238c646 LobstersItem: extract hard-coded submitter text
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:45:13 +05:30
Harsh Shandilya a7bd050013 LobstersItem: use existing BASE_URL field
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:42:54 +05:30
Harsh Shandilya 5ab5d1ece7 LobstersItem: fix submitter name alignment with avatar
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:41:49 +05:30
Harsh Shandilya 07930d416d build(app): remove kotlinCompilerVersion
It is deprecated now

'ComposeOptions.kotlinCompilerVersion is deprecated. Compose now uses the kotlin compiler defined in your buildscript.'

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:38:30 +05:30
Harsh Shandilya 929816c342 Revert "gradle: disable problematic flag"
Fixed in AGP 7.0.0-alpha05

This reverts commit 6b85bc51de.
2021-01-28 13:26:56 +05:30
Harsh Shandilya 9d2a0acfcf build: upgrade Room
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 12:04:14 +05:30
Harsh Shandilya b2719a263f build: sync Dagger Hilt gradle plugin version with library
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 12:03:24 +05:30
Harsh Shandilya 3eead80cb4 build: upgrade AGP
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 12:02:04 +05:30
Harsh Shandilya 82b1887f6d app: remove identical icon
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-26 11:16:25 +05:30
Harsh Shandilya dee0c54fde app: rename UrlLauncherAmbient to appease Lint
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-26 11:16:24 +05:30
Harsh Shandilya e1aa0e5bc6 app: remove customtabs dependency
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 19:15:51 +05:30
Harsh Shandilya 57a2f67646 build: pare down unnecessary Jetpack dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 18:58:57 +05:30
Harsh Shandilya 5f752ed251 build: upgrade Dagger
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 18:55:47 +05:30
Harsh Shandilya 7a8583e352 build: upgrade to Gradle 6.8.1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 18:45:32 +05:30
Harsh Shandilya 04658e99fd MainActivity: snap to top of list when pressing hottest posts tab
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-25 18:44:00 +05:30
Harsh Shandilya 45c3ec504f all: reformat
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-18 18:53:18 +05:30
Harsh Shandilya 6b85bc51de gradle: disable problematic flag
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-18 18:51:51 +05:30
Harsh Shandilya 19c5bac6d3 all: use Dagger Hilt VM injection
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-18 18:51:51 +05:30
Harsh Shandilya e9a55cc1db buildSrc: introduce versioning plugin
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-18 18:43:05 +05:30
Harsh Shandilya dc61aa07ac build: bump Dagger Hilt
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-15 11:19:05 +05:30
Harsh Shandilya a36ca26720 build: update Jetpack and Accompanist
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-14 16:02:35 +05:30
Harsh Shandilya a4e0c90fe9 build: bump Gradle
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-09 15:59:22 +05:30
Harsh Shandilya bf46187d0a build: bump AGP and transitive dependencies
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-09 15:54:05 +05:30
Harsh Shandilya a737f7c7da build: upgrade material and accompanist
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-24 04:46:33 +05:30
Harsh Shandilya a4f05c744e build: target Java 11
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-24 04:45:47 +05:30
Harsh Shandilya 7c2528f4a7 build: refactor for configuration cache compatibility
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-20 17:11:37 +05:30
Harsh Shandilya 156c58e544 app: increase horizontal padding in LobstersItem
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-18 13:10:29 +05:30
Harsh Shandilya 542b6c4e1a gradle: remove AGP suppression list
It's a pain to maintain and doesn't seem to be working either

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-18 13:08:23 +05:30
Harsh Shandilya 3cde52a3a5 app: silence proguard spam
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-18 13:07:04 +05:30
Harsh Shandilya 8abb5cbd3a app: remove extraneous padding from post lists
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-18 13:06:25 +05:30
Harsh Shandilya d0b2bbee15 gradle: sync properties with ReactiveCircus/streamlined
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-17 23:50:43 +05:30
Harsh Shandilya e504a2c591 model: don't unit test against the live server
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-17 12:06:14 +05:30
Harsh Shandilya 76f613f82f gradle: disable R8 full mode
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-17 11:43:11 +05:30
Harsh Shandilya 623a9ffcb5 app: switch from kotlinx to square
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-17 11:43:11 +05:30