Fix empty channels showing up as errored with RSS (#3824)

src/renderer/components/subscriptions-live/subscriptions-live.js

@@ -216,6 +216,17 @@ export default defineComponent({
         const response = await fetch(feedUrl)
 
         if (response.status === 404) {
+          // playlists don't exist if the channel was terminated but also if it doesn't have the tab,
+          // so we need to check the channel feed too before deciding it errored, as that only 404s if the channel was terminated
+
+          const response2 = await fetch(`https://www.youtube.com/feeds/videos.xml?channel_id=${channel.id}`, {
+            method: 'HEAD'
+          })
+
+          if (response2.status === 404) {
+            this.errorChannels.push(channel)
+          }
+
           return []
         }
 

src/renderer/components/subscriptions-shorts/subscriptions-shorts.js

@@ -157,6 +157,17 @@ export default defineComponent({
         const response = await fetch(feedUrl)
 
         if (response.status === 404) {
+          // playlists don't exist if the channel was terminated but also if it doesn't have the tab,
+          // so we need to check the channel feed too before deciding it errored, as that only 404s if the channel was terminated
+
+          const response2 = await fetch(`https://www.youtube.com/feeds/videos.xml?channel_id=${channel.id}`, {
+            method: 'HEAD'
+          })
+
+          if (response2.status === 404) {
+            this.errorChannels.push(channel)
+          }
+
           return []
         }
 

src/renderer/components/subscriptions-tab-ui/subscriptions-tab-ui.css

@@ -14,10 +14,6 @@
   right: 10px;
 }
 
-.channelBubble {
-  display: inline-block;
-}
-
 @media only screen and (max-width: 350px) {
   .floatingTopButton {
     position: absolute

src/renderer/components/subscriptions-tab-ui/subscriptions-tab-ui.vue

@@ -14,7 +14,6 @@
           :channel-name="channel.name"
           :channel-id="channel.id"
           :channel-thumbnail="channel.thumbnail"
-          class="channelBubble"
           @click="goToChannel(channel.id)"
         />
       </div>

src/renderer/components/subscriptions-videos/subscriptions-videos.js

@@ -216,7 +216,17 @@ export default defineComponent({
         const response = await fetch(feedUrl)
 
         if (response.status === 404) {
-          this.errorChannels.push(channel)
+          // playlists don't exist if the channel was terminated but also if it doesn't have the tab,
+          // so we need to check the channel feed too before deciding it errored, as that only 404s if the channel was terminated
+
+          const response2 = await fetch(`https://www.youtube.com/feeds/videos.xml?channel_id=${channel.id}`, {
+            method: 'HEAD'
+          })
+
+          if (response2.status === 404) {
+            this.errorChannels.push(channel)
+          }
+
           return []
         }